Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe the relationship between Singularity, SingularityCE and Apptainer #34

Conversation

warrickball
Copy link
Contributor

Following #32, some users might be confused about the relationship between Singularity, SingularityCE and Apptainer since SingularityCE was forked and Singularity renamed to Apptainer. This was already being managed in lessons developed from this repo but this PR adds a paragraph (in the the Getting Started episode) that explains the history and relationship between these entities.

My text started from this example that @jcohen02 linked in #32.

Copy link
Collaborator

@jcohen02 jcohen02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this PR @warrickball. I've suggested one possible edit to the second paragraph and wil leave it with you to decide if you're happy to make the suggested change, add your own revised version of the suggestion or you prefer to stick with the original text. Otherwise, this looks great.

_episodes/01-singularity-gettingstarted.md Outdated Show resolved Hide resolved
@warrickball
Copy link
Contributor Author

I'm happy with your changes and accepted them as is.

@multimeric
Copy link
Contributor

@jcohen02 can this be merged?

Copy link
Collaborator

@jcohen02 jcohen02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for adding this content @warrickball and apologies for this getting left for so long. As far as I can tell, the content here is still current so I will merge it.

@jcohen02 jcohen02 merged commit 384c710 into carpentries-incubator:gh-pages Sep 2, 2024
@jcohen02
Copy link
Collaborator

jcohen02 commented Sep 2, 2024

@jcohen02 can this be merged?

Yes, and thanks for highlighting this @multimeric! 🙂
The PR is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants