Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge 'Refactoring To Use a Pure Function' does not use solution implementation from previous challenge #394

Open
svenvanderburg opened this issue Oct 14, 2024 · 1 comment

Comments

@svenvanderburg
Copy link
Collaborator

In episode 3.4 we introduce a class-based solution for loading in csv files in analyse_data(): https://carpentries-incubator.github.io/python-intermediate-development/33-code-decoupling-abstractions/index.html#solution-1

In the later solution we still use the old implementation, whereas students at that point will have the class-based implementation of analyse_date() https://carpentries-incubator.github.io/python-intermediate-development/34-code-refactoring/index.html#exercise-refactoring-to-use-a-pure-function

svenvanderburg added a commit to esciencecenter-digital-skills/python-intermediate-development-gitlab that referenced this issue Nov 19, 2024
@svenvanderburg
Copy link
Collaborator Author

svenvanderburg commented Nov 19, 2024

Proposed fix: esciencecenter-digital-skills@9a1bbec

In addition: esciencecenter-digital-skills@8020659 to also make 'Exercise: Write Regression Tests' to use the mocked data source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant