Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'Test using a Mock implementation' challenge episode 3.3 #367

Open
3 tasks
mhagdorn opened this issue Jun 18, 2024 · 2 comments
Open
3 tasks

Improve 'Test using a Mock implementation' challenge episode 3.3 #367

mhagdorn opened this issue Jun 18, 2024 · 2 comments
Assignees

Comments

@mhagdorn
Copy link

mhagdorn commented Jun 18, 2024

The 'Test using a Mock implementation' challenge needs a few improvements:

Tasks

Preview Give feedback
@anenadic anenadic added this to the December2024-beta milestone Jul 31, 2024
@douglowe douglowe self-assigned this Aug 29, 2024
@svenvanderburg
Copy link
Collaborator

We should mention that the failing of the test is expected and that we will adapt the analyse_data function to return an array in the next episode: https://carpentries-incubator.github.io/python-intermediate-development/34-code-refactoring/index.html#exercise-write-regression-tests

@svenvanderburg svenvanderburg changed the title mocking data source for analyse_data Improve 'Test using a Mock implementation' episode 3.3 Oct 15, 2024
@svenvanderburg svenvanderburg changed the title Improve 'Test using a Mock implementation' episode 3.3 Improve 'Test using a Mock implementation' challenge episode 3.3 Oct 15, 2024
svenvanderburg added a commit to esciencecenter-digital-skills/python-intermediate-development-gitlab that referenced this issue Nov 19, 2024
@svenvanderburg
Copy link
Collaborator

svenvanderburg commented Nov 19, 2024

Proposed fix esciencecenter-digital-skills@8e59273 (which is slightly different from the task list above, but I think this works better)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants