-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Dimension Reduction Update #15
WIP: Dimension Reduction Update #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @bkmgit! Your effort is much appreciated.
I requested some minor changes on the tags that you use for the code blocks. If they aren't correctly formatted, the syntax highlighting doesn't work. It would also be nice to have Challenge and Solution tags for the exercises you proposed.
Let me know if we can help you with anything.
# Examine the dataset | ||
|
||
print(digits.data) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extraneous space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
|
||
X = digits.data | ||
y = digits.target | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extraneous space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
digits = datasets.load_digits() | ||
|
||
# Examine the dataset | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extraneous space
@vinisalazar Let me know if ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution. I understand there are the following additional changes:
- Fix tags in other episodes and setup page.
- Add
Gemfile
. - Rename files that were incorrectly numbered.
These are welcome changes, and although it'd be preferable to have them in separate PRs, given that this lesson is in an early development stage, I have no problem in including them in this one.
@colinsauze LGTM, what do you think?
Ok. Will start new branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I took a closer look and there's one last change: using double ##
instead of single #
in Exercise headers, or they won't render correctly.
At the moment, local build fails as some of the jekyll files have not been updated in a while |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
As for the Jekyll files: we are using the remote theme, so the Jekyll build should mostly be ok because of that. Could you provide more details of what is failing for you? |
Ok, build of current site works. My fork still has some old code. |
Work is now in #16 |
ensemble methods first draft
Draft for dimension reduction