Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Dimension Reduction Update #15

Closed
wants to merge 8 commits into from
Closed

WIP: Dimension Reduction Update #15

wants to merge 8 commits into from

Conversation

bkmgit
Copy link
Collaborator

@bkmgit bkmgit commented Jun 25, 2021

Draft for dimension reduction

Copy link
Collaborator

@vinisalazar vinisalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @bkmgit! Your effort is much appreciated.

I requested some minor changes on the tags that you use for the code blocks. If they aren't correctly formatted, the syntax highlighting doesn't work. It would also be nice to have Challenge and Solution tags for the exercises you proposed.

Let me know if we can help you with anything.

# Examine the dataset

print(digits.data)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extraneous space

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.


X = digits.data
y = digits.target

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extraneous space

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

_episodes/05-dimensionality-reduction.md Outdated Show resolved Hide resolved
_episodes/05-dimensionality-reduction.md Outdated Show resolved Hide resolved
_episodes/05-dimensionality-reduction.md Outdated Show resolved Hide resolved
_episodes/05-dimensionality-reduction.md Outdated Show resolved Hide resolved
_episodes/05-dimensionality-reduction.md Outdated Show resolved Hide resolved
_episodes/05-dimensionality-reduction.md Show resolved Hide resolved
_episodes/05-dimensionality-reduction.md Outdated Show resolved Hide resolved
digits = datasets.load_digits()

# Examine the dataset

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extraneous space

@bkmgit
Copy link
Collaborator Author

bkmgit commented Jun 25, 2021

@vinisalazar Let me know if ok

Copy link
Collaborator

@vinisalazar vinisalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution. I understand there are the following additional changes:

  • Fix tags in other episodes and setup page.
  • Add Gemfile.
  • Rename files that were incorrectly numbered.

These are welcome changes, and although it'd be preferable to have them in separate PRs, given that this lesson is in an early development stage, I have no problem in including them in this one.

@colinsauze LGTM, what do you think?

@bkmgit
Copy link
Collaborator Author

bkmgit commented Jun 25, 2021

Ok. Will start new branch.

Copy link
Collaborator

@vinisalazar vinisalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I took a closer look and there's one last change: using double ## instead of single # in Exercise headers, or they won't render correctly.

_episodes/05-dimensionality-reduction.md Outdated Show resolved Hide resolved
_episodes/05-dimensionality-reduction.md Outdated Show resolved Hide resolved
_episodes/05-dimensionality-reduction.md Outdated Show resolved Hide resolved
@bkmgit
Copy link
Collaborator Author

bkmgit commented Jun 25, 2021

At the moment, local build fails as some of the jekyll files have not been updated in a while

Copy link
Collaborator

@vinisalazar vinisalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@vinisalazar
Copy link
Collaborator

vinisalazar commented Jun 25, 2021

As for the Jekyll files: we are using the remote theme, so the Jekyll build should mostly be ok because of that. Could you provide more details of what is failing for you?

@bkmgit
Copy link
Collaborator Author

bkmgit commented Jun 25, 2021

Ok, build of current site works. My fork still has some old code.

@bkmgit
Copy link
Collaborator Author

bkmgit commented Jun 25, 2021

Work is now in #16

@bkmgit bkmgit closed this Jun 25, 2021
@vinisalazar vinisalazar mentioned this pull request Jun 28, 2021
colinsauze pushed a commit that referenced this pull request Sep 25, 2024
ensemble methods first draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants