Use argparse to add --output flag to plotting script #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files or spoofing. Results of any additional workflows will appear here when they are done. |
|
Well that's frustrating, even the updated CI doesn't work |
Incorporate @ocaisa's file error handling. Co-authored-by: ocaisa <[email protected]>
tkphd
force-pushed
the
script
branch
2 times, most recently
from
534e637 to
f8d1da5
Compare
ocaisa
approved these changes
Jun 12, 2024
|
Nah, we'll get the CI working. It looks like Toby has been actively supporting related issues on the Slack #workbench; I'm working through his advice to others. |
|
... or maybe it won't help, and merging this will allow us to try PRs that change the Actions instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (programmed by an alleged human) uses the
argparsemodule to document theplot_terse_amdahl_results.pyprogram, adding a--outputflag (required), revoking the requirement of JPEG output (matplotlib will guess the appropriate format from the filename, and error out if unknown), and updates the lesson content to use the new flag.Supersedes #17. Closes #17.