Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 01-introduction-to-high-dimensional-data.Rmd #67

Merged
merged 13 commits into from
Jun 7, 2022

Conversation

hannesbecher
Copy link
Collaborator

Instructions

Thanks for contributing! ❤️

If this contribution is for instructor training, please email the link to this contribution to
[email protected] so we can record your progress. You've completed your contribution
step for instructor checkout by submitting this contribution!

Keep in mind that lesson maintainers are volunteers and it may take them some time to
respond to your contribution. Although not all contributions can be incorporated into the lesson
materials, we appreciate your time and effort to improve the curriculum. If you have any questions
about the lesson maintenance process or would like to volunteer your time as a contribution
reviewer, please contact The Carpentries Team at [email protected].

You may delete these instructions from your comment.

- The Carpentries

@catavallejos
Copy link
Collaborator

one additional general comment, we should be consistent when loading libraries. Either use e.g. library(MASS) or library("MASS") but not a mix. This comment applies to all episodes.

@catavallejos
Copy link
Collaborator

Same applies about the format used when calling libraries in the text. Either all in bold or not (I think bold is missing when introducing lasso2.

Copy link
Collaborator Author

@hannesbecher hannesbecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy

@hannesbecher
Copy link
Collaborator Author

one additional general comment, we should be consistent when loading libraries. Either use e.g. library(MASS) or library("MASS") but not a mix. This comment applies to all episodes.

I generally don't use quotes in library().

@hannesbecher
Copy link
Collaborator Author

Same applies about the format used when calling libraries in the text. Either all in bold or not (I think bold is missing when introducing lasso2.

All bold, as listed in Ailith's tick list. I may have missed that one.

hannesbecher and others added 11 commits June 7, 2022 17:39
Co-authored-by: Catalina Vallejos <[email protected]>
Co-authored-by: Catalina Vallejos <[email protected]>
Co-authored-by: Catalina Vallejos <[email protected]>
Co-authored-by: Catalina Vallejos <[email protected]>
Co-authored-by: Catalina Vallejos <[email protected]>
Co-authored-by: Catalina Vallejos <[email protected]>
Co-authored-by: Catalina Vallejos <[email protected]>
Co-authored-by: Catalina Vallejos <[email protected]>
Co-authored-by: Catalina Vallejos <[email protected]>
Co-authored-by: Catalina Vallejos <[email protected]>
@alanocallaghan
Copy link
Collaborator

When teaching people, I tend to type library("package") because it's consistent between library and install.packages (or BiocManager::install, etc), and doesn't invite questions about non-standard evaluation that have complicated answers I am not very good at delivering.

@catavallejos
Copy link
Collaborator

catavallejos commented Jun 7, 2022

When teaching people, I tend to type library("package") because it's consistent between library and install.packages (or BiocManager::install, etc), and doesn't invite questions about non-standard evaluation that have complicated answers I am not very good at delivering.

I don't normally use quotes for this, but I take your argument. @hannesbecher can you please make sure that all library calls have the quotes? (for this and other episodes).

I will merge/close that issue and add that change myself

@catavallejos catavallejos merged commit eae4126 into carpentries-incubator:main Jun 7, 2022
alanocallaghan pushed a commit to alanocallaghan/high-dimensional-stats-r that referenced this pull request Apr 16, 2024
…HBintro

Update 01-introduction-to-high-dimensional-data.Rmd pre-third delivery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants