Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux/mac fix for setup #178

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

mallewellyn
Copy link
Contributor

@mallewellyn mallewellyn commented Apr 2, 2024

This definitely needs looking at/tested, especially on Mac. I tested on Linux and it seems to work and removes igraph/minfi issues.

To explain PR:

  • Because the second link in Error in Linux setup #160 requires a mixture of R and bash to install dependencies, it could be easier to use the first link and require all system dependencies are installed. Checked the latter and the dependencies don't seem to take too long to install. Could replace the Linux caveat (currently about igraph) with something similar to the code I've proposed.
  • Tested on Ubuntu without any problems and seems to resolve igraph issue. I actually don't know that the Ubuntu code can be used on Mac as stated in this new version so will need to be tested/checked (my understanding is that the Mac terminal uses bash?).

setup.md Outdated Show resolved Hide resolved
@alanocallaghan alanocallaghan self-requested a review April 3, 2024 14:12
setup.md Outdated Show resolved Hide resolved
@alanocallaghan alanocallaghan merged commit 1bd1447 into carpentries-incubator:main Apr 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants