generated from carpentries-incubator/template
-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes to episode 6, tasks 1-9 #147
Merged
alanocallaghan
merged 13 commits into
carpentries-incubator:main
from
mallewellyn:mary-suggestions-task1plus-ep6
Mar 25, 2024
Merged
changes to episode 6, tasks 1-9 #147
alanocallaghan
merged 13 commits into
carpentries-incubator:main
from
mallewellyn:mary-suggestions-task1plus-ep6
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainly to motivate by clarifying differences compared to pca and fa since these are already discussed
think it's clearer to explain believing in clusters after fully describing what clusters are
unclear what a specified clustering algorithm is and how this increases our confidence that data can be partitioned into groups at this stage
…t convergence looks like, tasks 8 and 9 Picking initial points randomly here may be misleading for someone just looking up the method from this section. Have simply omitted and said that this is discussed below. Also, have removed the word convergence in favour of a description of what convergence looks like
Co-authored-by: Alan O'Callaghan <[email protected]>
alanocallaghan
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great just minor problems
Co-authored-by: Alan O'Callaghan <[email protected]>
All fixed above :) |
alanocallaghan
approved these changes
Mar 25, 2024
Awesome thanks, great addition |
alanocallaghan
added a commit
to alanocallaghan/high-dimensional-stats-r
that referenced
this pull request
Apr 16, 2024
…mary-suggestions-task1plus-ep6 changes to episode 6, tasks 1-9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely re-writing motivation and methodology sections in line with tasks 1-9 of #119
Particularly tries to clarify the differences between clustering and PCA/FA from the outset (even though they're completely different methods, I think a reader would benefit from this being apparent immediately).
Also moves the section on believing in clusters to after the method is explained - I think how to believe in a cluster is easier to understand if we know what clusters are fully first