generated from carpentries-incubator/template
-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes to episode 5, all tasks #146
Merged
alanocallaghan
merged 24 commits into
carpentries-incubator:main
from
mallewellyn:mary-code-suggestions-ep5
Mar 6, 2024
Merged
changes to episode 5, all tasks #146
alanocallaghan
merged 24 commits into
carpentries-incubator:main
from
mallewellyn:mary-code-suggestions-ep5
Mar 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is required outside of the include=FALSE code as required in visible code.
to differentiate from PCA also added latent variable definition and corrected "a-priori"
both CFA and EFA are data driven.
for consistency with other episodes
hard to understand without fully understanding FA
same as changes to other episodes
we don't use a high-dimensional dataset after
…bility do you agree?
mostly careful wording since cannot accept a null hypothesis and removing hard threshold for the significance level
already have head()
Co-authored-by: Alan O'Callaghan <[email protected]>
alanocallaghan
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks
So quick! Thanks Alan! |
alanocallaghan
pushed a commit
to alanocallaghan/high-dimensional-stats-r
that referenced
this pull request
Apr 16, 2024
* add required library(here) before first visible code I think this is required outside of the include=FALSE code as required in visible code. * add comment about FA and interpretability, tasks 1, 3, 5 to differentiate from PCA also added latent variable definition and corrected "a-priori" * brackets around first latent ref * task 2 * remove data-driven, task 4 both CFA and EFA are data driven. * change title of student scores section, task 6 for consistency with other episodes * move advantages and disadvantages to the end, task 7 hard to understand without fully understanding FA * add reasoning for low-dim data set again, task 7 same as changes to other episodes * remove initially we don't use a high-dimensional dataset after * complete task 8 * elaborate that both use linear combinations and reason for interpretability do you agree? * add how many factors title for consistency with pca episode, task 10 * in practise to in practice, task 11 * previous commit task 12 * minor rewording to how to find the number of factors, task 13 * add "then", task 14 * rewording around hypothesis test, task 15 mostly careful wording since cannot accept a null hypothesis and removing hard threshold for the significance level * typo fix, task 16 * add consider for individual learners, task 18 * fig caption and alt text for first table, part task 19 * remove View(prostate) already have head() * alt text and captions for biplot, complete task 19 * emphasise a priori Co-authored-by: Alan O'Callaghan <alan.ocallaghan =@=outlook.com> --------- Co-authored-by: Alan O'Callaghan <alan.ocallaghan =@=outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatively minor changes to episode 5. Largely:
To address all tasks of #118