Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to episode 5, all tasks #146

Conversation

mallewellyn
Copy link
Contributor

Relatively minor changes to episode 5. Largely:

  • Highlighting the differences between PCA and FA in the introduction. This probably needs to be checked in particular to ensure you agree!
  • Moving discussion of advantages and disadvantages to the end so that the method is fully understood first.
  • Rewording the hypothesis test to avoid saying that we accept the null hypothesis and hard thresholding the significance level.
  • Editing section headings for consistency with the previous episodes (e.g., adding the dataset name to sections containing datasets).
  • Other rewording but minor.
  • Fixing typos.
  • Adding alt text and captions.

To address all tasks of #118

I think this is required outside of the include=FALSE code as required in visible code.
to differentiate from PCA
also added latent variable definition and corrected "a-priori"
both CFA and EFA are data driven.
for consistency with other episodes
hard to understand without fully understanding FA
same as changes to other episodes
we don't use a high-dimensional dataset after
mostly careful wording since cannot accept a null hypothesis and removing hard threshold for the significance level
already have head()
Co-authored-by: Alan O'Callaghan <[email protected]>
Copy link
Collaborator

@alanocallaghan alanocallaghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks

@alanocallaghan alanocallaghan merged commit ca0d385 into carpentries-incubator:main Mar 6, 2024
3 checks passed
@mallewellyn
Copy link
Contributor Author

So quick! Thanks Alan!

@mallewellyn mallewellyn deleted the mary-code-suggestions-ep5 branch March 6, 2024 10:03
alanocallaghan pushed a commit to alanocallaghan/high-dimensional-stats-r that referenced this pull request Apr 16, 2024
* add required library(here) before first visible code

I think this is required outside of the include=FALSE code as required in visible code.

* add comment about FA and interpretability, tasks 1, 3, 5

to differentiate from PCA
also added latent variable definition and corrected "a-priori"

* brackets around first latent ref

* task 2

* remove data-driven, task 4

both CFA and EFA are data driven.

* change title of student scores section, task 6

for consistency with other episodes

* move advantages and disadvantages to the end, task 7

hard to understand without fully understanding FA

* add reasoning for low-dim data set again, task 7

same as changes to other episodes

* remove initially

we don't use a high-dimensional dataset after

* complete task 8

* elaborate that both use linear combinations and reason for interpretability

do you agree?

* add how many factors title for consistency with pca episode, task 10

* in practise to in practice, task 11

* previous commit task 12

* minor rewording to how to find the number of factors, task 13

* add "then", task 14

* rewording around hypothesis test, task 15

mostly careful wording since cannot accept a null hypothesis and removing hard threshold for the significance level

* typo fix, task 16

* add consider for individual learners, task 18

* fig caption and alt text for first table, part task 19

* remove View(prostate)

already have head()

* alt text and captions for biplot, complete task 19

* emphasise a priori

Co-authored-by: Alan O'Callaghan <alan.ocallaghan =@=outlook.com>

---------

Co-authored-by: Alan O'Callaghan <alan.ocallaghan =@=outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants