changes to episode 3, tasks 1-8 #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this a fair summary?
doesn't the previous example show this too? Collinearity isn't a distinct issue to having singularities?
check this is correct
if keeping the other changes
|
Looks great! |
ailithewing
reviewed
Mar 12, 2024
ailithewing
reviewed
Mar 12, 2024
ailithewing
reviewed
Mar 12, 2024
ailithewing
reviewed
Mar 12, 2024
Co-authored-by: Ailith Ewing <[email protected]>
Co-authored-by: Ailith Ewing <[email protected]>
Co-authored-by: Ailith Ewing <[email protected]>
|
Yes totally agree! Have committed all those changes above |
ailithewing
approved these changes
Mar 13, 2024
alanocallaghan
pushed a commit
to alanocallaghan/high-dimensional-stats-r
that referenced
this pull request
Apr 16, 2024
…mary-suggestions-task1plus-ep3 changes to episode 3, tasks 1-8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All with respect to how the lesson is motivated and the description of singularities (tasks 1-8 of #115).
Also tried to simplify the description of singularities (thought defining the inverse was maybe too much information and it's not used later anyway).
Particular checks may be needed re additions that singularities may occur due to high correlations between features.