Resolve carpentries lab review likeajumprope #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvanderburg
changed the title
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files or spoofing. Results of any additional workflows will appear here when they are done. |
svenvanderburg
commented
Jan 13, 2025
5 tasks
carschno
reviewed
Jan 13, 2025
There was a problem hiding this comment.
All the changes look good to me, but the build action fails: https://github.com/carpentries-incubator/deep-learning-intro/actions/runs/12747591898/job/35525983576?pr=523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #522