-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes from Carpentries Lab review #444
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/deep-learning-intro/compare/md-outputs..md-outputs-PR-444 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-02-18 13:11:42 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some markup issues remain (missing alt-text, http
instead of https
links), but they are not related to these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Auto-generated via {sandpaper} Source : 9895279 Branch : main Author : Djura <[email protected]> Time : 2024-02-27 10:12:16 +0000 Message : Merge pull request #444 from carpentries-incubator/small-fixes-review Small fixes from Carpentries Lab review
Auto-generated via {sandpaper} Source : a09e23d Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-02-27 10:14:07 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 9895279 Branch : main Author : Djura <[email protected]> Time : 2024-02-27 10:12:16 +0000 Message : Merge pull request #444 from carpentries-incubator/small-fixes-review Small fixes from Carpentries Lab review
Fixes: