Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using concat method instead of append #63

Open
wants to merge 2 commits into
base: legacy/gh-pages
Choose a base branch
from

Conversation

mirhnius
Copy link

@mirhnius mirhnius commented Jan 4, 2024

Resolving issue #62

@mirhnius
Copy link
Author

mirhnius commented Jan 8, 2024

In the recent commit, I fixed a type incompatibility bug.

@jhlegarreta
Copy link
Collaborator

@mirhnius When git blaming eda4b21 I see that the output images have also changed:
https://github.com/carpentries-incubator/SDC-BIDS-sMRI/blame/eda4b219117046b4152c5f865649402abcd156f1/code/1_sMRI_modalities.ipynb

If it is just a deprecation error, then I assume the result of both commands should be the same. Can you please explain why the output images are changed?

When git blaming 457e4d0 it can be seen that the output images prior to the int64 to int32 change:
https://github.com/carpentries-incubator/SDC-BIDS-sMRI/blame/457e4d00554d339070720129f0593396d1aacd7e/code/4_sMRI_segmentation_parcellation.ipynb#L1204

are also changed, e.g.
https://github.com/carpentries-incubator/SDC-BIDS-sMRI/blame/457e4d00554d339070720129f0593396d1aacd7e/code/4_sMRI_segmentation_parcellation.ipynb#L549

Why is this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants