Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT] - Update contributing guidelines, author links, and lesson outline #13

Merged
merged 5 commits into from
Nov 26, 2020
Merged

[MAINT] - Update contributing guidelines, author links, and lesson outline #13

merged 5 commits into from
Nov 26, 2020

Conversation

jerdra
Copy link
Collaborator

@jerdra jerdra commented Sep 24, 2020 •
edited
Loading

No description provided.

@jerdra jerdra changed the title [MAINT] - Update README.md [MAINT] - Update contributing guidelines, author links, and lesson outline Sep 24, 2020
kaitj
kaitj requested changes Sep 24, 2020
View reviewed changes
Copy link
Collaborator

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me - just a few spelling changes.

Can't recall the markdown format exactly for tables either, so the spacing thing mentioned in the review comments may not even be an issue.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
josephmje
josephmje reviewed Sep 24, 2020
View reviewed changes
Copy link
Contributor

@josephmje josephmje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just made a few suggestions to the Background

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jerdra and others added 2 commits September 28, 2020 15:28
@jerdra @josephmje
Update README.md
c68a567 
Co-authored-by: Michael Joseph <[email protected]>
@jerdra @josephmje
Update README.md
3bdb19e 
Co-authored-by: Michael Joseph <[email protected]>
@jerdra jerdra merged commit 0eea94b into carpentries-incubator:gh-pages Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmje josephmje josephmje left review comments

@kaitj kaitj kaitj requested changes

@ostanley ostanley Awaiting requested review from ostanley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerdra @kaitj @josephmje