Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Switch to JupyterLab #200

Merged
merged 1 commit into from
Nov 8, 2021
Merged

ENH: Switch to JupyterLab #200

merged 1 commit into from
Nov 8, 2021

Conversation

jhlegarreta
Copy link
Contributor

Switch to JupyterLab: change mentions in documentation from Jupyter Notebooks to JupyterLab.

@jhlegarreta jhlegarreta added type:enhancement Propose enhancement to the lesson type:instructor guide Issue with the instructor guide type:template and tools Issue about template and tools labels Nov 8, 2021
@netlify
Copy link

netlify bot commented Nov 8, 2021

✔️ Deploy Preview for carpentries-dmri ready!

🔨 Explore the source changes: 08512d6

🔍 Inspect the deploy log: https://app.netlify.com/sites/carpentries-dmri/deploys/618935dac770db0007f154af

😎 Browse the preview: https://deploy-preview-200--carpentries-dmri.netlify.app

@jhlegarreta
Copy link
Contributor Author

Well, contrary to what I thought in #193 (comment), it looks like JupyterLab is likely to have less or no impact on the notebook execution, since it is not in our requirements, and thus, not required to run the notebooks, and I now realize that the binder instance was already using it.

Anyways, we are more likely to get support I think.

setup.md Outdated Show resolved Hide resolved
Copy link
Contributor

@josephmje josephmje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the transition @jhlegarreta! I just added some text to better introduce JupyterLab and Binder.

Also, I noticed during the lesson last Friday that the exercise/solutions package we're currently using only works with Jupyter Notebook. So we will also need to find an upgraded package to transition that as well.

@jhlegarreta
Copy link
Contributor Author

Also, I noticed during the lesson last Friday that the exercise/solutions package we're currently using only works with Jupyter Notebook. So we will also need to find an upgraded package to transition that as well.

😟 I did not look into that. Looks like a rabbit hole then. Any idea if there is a fix/upgrade/alternative to the exercise/solution package?

Switch to `JupyterLab`: change mentions in documentation from `Jupyter
Notebooks` to `JupyterLab`.
@josephmje
Copy link
Contributor

😟 I did not look into that. Looks like a rabbit hole then. Any idea if there is a fix/upgrade/alternative to the exercise/solution package?

I previously tried out the Solutions extension but I had trouble installing it.

Another workaround might be with code folding

@jhlegarreta
Copy link
Contributor Author

jhlegarreta commented Nov 8, 2021

I previously tried out the Solutions extension but I had trouble installing it.
Another workaround might be with code folding

OK. You may want to open an issue to keep track of that.

In any case it looks like switching to JupyterLab is necessary to keep up with the Jupyter evolution.

I will merge once the CI becomes green.

@jhlegarreta jhlegarreta merged commit ff8bcd1 into carpentries-incubator:main Nov 8, 2021
@jhlegarreta jhlegarreta deleted the SwitchToJupyterLab branch November 8, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Propose enhancement to the lesson type:instructor guide Issue with the instructor guide type:template and tools Issue about template and tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants