Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Went through the code #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

xortizross
Copy link
Contributor

Added what I would have done and some questions. Overall I didn't come up with any big issues, although the whole thing doesn't feel right? Are we going about this the right way? I did find a discrepancy with the proportions.

@kaijagahm You don't need to approve the pull, but this gives you a chance to review it?

Added what I would have done and some questions. Overall I didn't come up with any big issues, although the whole thing doesn't feel right? Are we going about this the right way? I did find a discrepancy with the proportions
@xortizross xortizross requested a review from kaijagahm December 12, 2024 21:19
Copy link

github-actions bot commented Dec 12, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/R-help-reprexes/compare/md-outputs..md-outputs-PR-91

The following changes were observed in the rendered markdown documents:

 .DS_Store                      |  Bin 6148 -> 6148 bytes
 4-minimal-reproducible-code.md |   55 ++
 config.yaml (new)              |   81 +++
 md5sum.txt                     |    2 +-
 renv.lock (new)                | 1092 ++++++++++++++++++++++++++++++++++++++++
 5 files changed, 1229 insertions(+), 1 deletion(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-12-12 21:21:13 +0000

github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
@peterlaurin peterlaurin self-requested a review December 17, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant