Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom XML Key improvements #945

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Conversation

caronc
Copy link
Owner

@caronc caronc commented Sep 9, 2023

Description:

Related issue (if applicable): #908

Improvements to the XML Key Handling (and Test Cases) based on some minor bugs found in the JSON version.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@908-custom-xml-service-improvements

# Test out the changes with the following command:
# The below renames the Message Stanza to Body
apprise -t "Test Title" -b "Test Message" \
  "xml://localhost/:Message:Body

@codecov-commenter
Copy link

Codecov Report

Patch coverage is 100.00% of modified lines.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Changed Coverage
apprise/plugins/NotifyXML.py 100.00%

📢 Thoughts on this report? Let us know!.

@caronc caronc merged commit 15e16ad into master Sep 10, 2023
@caronc caronc deleted the 908-custom-xml-service-improvements branch October 8, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants