Refactored SSL/Auth handling of Emails #774
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): #773 and apprise/discussion/760
Better handling of Email URLs:
ssl=
is exclusively set to a secure method (such asssl
, orstarttls
), then it is implied thatmailto://
should have beenmailtos://
465
when themode=ssl
(and not otherwise specified to be something different) and is587
whenmode=starttls
. Prior to this PR, it always defaulted to587
(the ssl mode was not considered).Checklist
flake8
)Testing
Anyone can help test this source code as follows: