Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync #7

Merged
merged 122 commits into from
Mar 15, 2021
Merged

sync #7

merged 122 commits into from
Mar 15, 2021

Conversation

carolinan
Copy link
Owner

No description provided.

mtias and others added 30 commits March 4, 2021 12:21
- Modifies all default template descriptions.
* Update the category icons.

* Address feedback.
Make preset values !important

Given how the style system works, !important is a good choice
for preset classes the user attaches to the post content.
If those values need to be overridden, in addition to regular CSS,
we can offer hooks for the theme.json processing,
so plugins have an alternate mechanism to modify this behavior.
…#29521)

* Print nothing if there are no results in Query block

* move empty check up in code
* Wip: Mobile RichText - Updating old value after splitting

* Mobile - Fix splitting/merging issues and keyboard jumpiness on Android

* Mobile - RichText - Add isIOS check for componentDidUpdate and use blockEditorStore

* Mobile - RichText - Prevent onTextUpdate on Android
* Components: Add Divider

* Update documentation for Divider component and README

* Update snapshot tests with new toMatchStyleDiffSnapshot

Co-authored-by: Jon Q <[email protected]>
* Add describedBy to button

* Add TooltipButton

* Add test and story for describedBy

* Add README and story

* Add JSDoc example for TooltipButton in export

* Add adapter

* Update snapshot tests

Co-authored-by: Jon Q <[email protected]>
* Pin SHA values as version numbers for 3rd party GHAs.
* Pin additional 3rd party actions to SHA values.
* Swap the Chevron icon button for a text button

* use ToolbarButton component

Co-authored-by: Addison-Stavlo <[email protected]>
* Block edit: avoid memoized block context in favour of useSelect

* Guard for no client ID
…ted version (#29542)

* Add missing deprecation attribute for content position

* Add new fixture for cover contentPosition deprecation

* Update changelog
* Drop zone: fix media lib duplicate issue

* Use ref effect
* Add Columns transform from Media & Text

* Remove isMatch and reformat

* add text and link colors in transformation

Co-authored-by: ntsekouras <[email protected]>
* Remove base control negative help text margin

* Remove unusued stylesheet
* Docs: Add info about npm release types and their schedule

* Clarify the development release purpose
The refactor of withNotices in #28676 introduced a bug where the
functions within `noticeOperations` were changing on every render. That
meant that if they were present in the dependency array of a useEffect,
then the effect would trigger causing an infinite loop.

This was partially fixed with #29491, but there are other instances
where the noticeOperations object itself is being listed as a
dependency, and so the problem persists.

As suggested by @stokesman
#29491 (comment)
this change memoizes the whole object.
* Clean up unused modules

* Remove nonsense param annotation

* docgen: A support for TypeScript annotations

* Bound eslint disable rule to typedef definitions

* Add comment pointing to the list of types

* Return early if is using jsdoc type

* Add tests for JSDoc type

* Return empty if no JSDoc type and TS type cannot be inferred

* Simplify

* Add tests and fixes for get-type-annotation

* Do not swallow helpful errors and make errors more descriptive

* Add tests covering index access, import, params, tuple, rest, and predicate

* Move nodes into fixtures

* Clean up duplicated import

* Add support for qualified type references

* Update CHANGELOG and README for TypeScript support

Co-authored-by: André <[email protected]>
* WP Block Styles: Only load in the editor if a theme opts in, or if it doesn't add any editor styles

* Check that the array exists

* Update lib/client-assets.php

Co-authored-by: Jeff Ong <[email protected]>

Co-authored-by: Jeff Ong <[email protected]>
… "Plain" permalink structure. (#29394)

* Table of Contents block: fix links when in archive loop.

This also fixes links for posts using the default "Plain" permalink structure.

* Don't add page query arg if post isn't paginated.
* Try: Hide tip from multiple paragraphs, version 1.

This one revisits work from #27995 (comment).

* Remove hover.
talldan and others added 29 commits March 11, 2021 09:33
* Fix navigation editor link search suggestions

* Add e2e test

* Try improving test robustness

* Update button text in test

* Make tests pass in CI
* WIP for term-description block

* load the block.

* better safe than sorry

* Add more supports

* add fixtures files

* use padding instead of height so border can adapt depending on font-size

* Change the icon

Use icon from #27989 (comment)

* Update packages/icons/src/library/term-description.js

Co-authored-by: Nik Tsekouras <[email protected]>

* address feedback

* Add description

* reverse condition & logic

* Change placeholder text

* Simplify

Co-authored-by: Nik Tsekouras <[email protected]>
* Fix navigation editor saving

* Update error message and tests
…8701)

* Add preload_paths filter for widgets screen and full site editing

* Add preloading system in for navigation editor too

* Add a function to initialize each block-based editor the same way

* Fix function documentation coding standards

* Define a $editor_name local variable for readibiilty in {$editor_name}_preload_paths filter name

* Add {$editor_name}_preload_paths filter documentation

* Make $editor_name and $editor_script_handle parameters of gutenberg_initialize_editor() function

* Replace gutenberg_initialize_editor() calls with its new parameters
This effects Android only. Removes the cancel button from the settings options (SelectControl)
* Site Editor: prevent navigation panel focus when hidden

* Remove unneeded faux border on navigation toggle button
- Use separate tests database service
- Configure database credentials in every service
- Set wp-config.php to be writable

Co-authored-by: Riad Benguella <[email protected]>
Co-authored-by: Noah Allen <[email protected]>
* query title - archive title

* add fixtures and polish

* Update packages/block-library/src/query-title/index.php

Co-authored-by: Carolina Nymark <[email protected]>

* add placeholder styles

* default to h1

Co-authored-by: Carolina Nymark <[email protected]>
* Adds drag handle to block selection button in navigation mode

* Make handle dark.

* Dropper shadow.

* makes the block selection button look like the daggable chip plus block name

* fix slight off vertical centering

* Make select mode chip accurate.

* Make draggable chip accurate.

Co-authored-by: Andrei Draganescu <[email protected]>
Co-authored-by: jasmussen <[email protected]>
…9715)

* Add iOS platform version to iOS local e2e caps

* Add iOS platform version automatically in e2e tests

When running the iOS e2e tests locally, we no longer require to specify the platform version because we can fetch the available iOS simulator runtimes and pick the latest one.

* Remove unnecessary condition when setting up the driver

* Add showXcodeLog capability

* Increase WDA launch timeout

* Revert "Add showXcodeLog capability"
…trols (#29816)

* Update block design principles with a new section on how to group controls

This takes a first stab at creating new documentation for block toolbar group best practices.

See also #25983.

* Address feedback.
* Try new block inserter keyboard navigation

* Refactor code

* Pass aria-orientation to listbox

* Update package.json

* Address review comments

* Add announcement

* Import composite from @wordpress/components

* Fix import names

* Fix keyboard navigation on search results

* Fix e2e test

* Announce instructions after block and group name
* Cover: Allow drag n drop media replacement

See #26388.

* Update transition duration and use grid unit for positioning
Co-authored-by: Ari Stathopoulos <[email protected]>
* Refactor ServerSideRender to use hooks.

* Rename fetch to fetchData.
Removes the option to toggle fullscreen mode in the Site Editor.
From now on it will always be on, similar to Customizer.
* Release script: Update react-native-editor version to 1.47.0

* Release script: Update with changes from 'npm run core preios'

* [RNMobile] Ignore column width attribute when empty (#29015)

* Ignore empty width attribute in columns

The editor was crashing when attempting to render a column block which contained an empty width attribute (i.e `<!-- wp:column {"width":""} -->`.
The exception occurred when accessing a property of an undefined object, so adding a default object (`|| {}`) fixes this by allowing the property to be accessed.

* Update react-native-editor changelog

* Add missing dependency to useSelect in columns block

Co-authored-by: Carlos Garcia <[email protected]>

* Update editor changelog

* Mobile - RichText - Restore onSelectionChange when its focused (#29074)

* Adds null check before function call

* [RNMobile] Merge 1.46.1 beta fix release to 1.47.0 (#29044)

* Release script: Update react-native-editor version to 1.46.1

* Release script: Update with changes from 'npm run core preios'

* Update react-native-editor CHANGELOG

* [RNMobile] Add capability to bridge to show/hide audio block (#28952)

* [RNMobile] Ignore column width attribute when empty (#29015)

* Update react-native-editor CHANGELOG

* Fixes minor changelog alignement issue

* Add Stories bridge methods for iOS (#29083)

Add missing bridge methods for the Stories block. The absence of these
threw an error, even though Stories block isn't fully supported for iOS
just yet.

Co-authored-by: Ceyhun Ozugur <[email protected]>
Co-authored-by: Paul Von Schrottky <[email protected]>
Co-authored-by: Antonis Lilis <[email protected]>
Co-authored-by: David Calhoun <[email protected]>

* Release script: Update react-native-editor version to 1.48.0

* Release script: Update with changes from 'npm run core preios'

* [Mobile] - Fix splitting/merging of Paragraph and Heading (#29502)

* Wip: Mobile RichText - Updating old value after splitting

* Mobile - Fix splitting/merging issues and keyboard jumpiness on Android

* Mobile - RichText - Add isIOS check for componentDidUpdate and use blockEditorStore

* Mobile - RichText - Prevent onTextUpdate on Android

* Update changelog

* Changelog - fix typo

* Revert "[Mobile] - Fix splitting/merging of Paragraph and Heading (#29502)"

This reverts commit a14915f.

* Revert "Rich text: keep block ID on split (#28505)"

This reverts commit 4b9d13f.

* Release script: Update react-native-editor version to 1.47.1

* Release script: Update with changes from 'npm run core preios'

* Change the maximum items per page of reusable block fetch

* Release script: Update react-native-editor version to 1.48.1

* Release script: Update with changes from 'npm run core preios'

* Change the maximum items per page of reusable block fetch

* Add replace block content by clientID

* Add item to release notes about `replaceBlock` method

* Revert "Revert "Rich text: keep block ID on split (#28505)""

This reverts commit 956cdfc.

Co-authored-by: Antonis Lilis <[email protected]>
Co-authored-by: Paul Von Schrottky <[email protected]>
Co-authored-by: David Calhoun <[email protected]>
Co-authored-by: Gerardo Pacheco <[email protected]>
Co-authored-by: Ceyhun Ozugur <[email protected]>
Co-authored-by: Enej Bajgoric <[email protected]>
Co-authored-by: Brandon Titus <[email protected]>
* Don't display Guide's page control if there is only one page

* Tweak margins so Guide contents don't rely on the PageControl margins
@carolinan carolinan merged commit 30c4ec7 into carolinan:add/post-comments-link Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.