Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with trunk #12

Merged
merged 170 commits into from
Mar 31, 2021
Merged

Sync with trunk #12

merged 170 commits into from
Mar 31, 2021

Conversation

carolinan
Copy link
Owner

No description provided.

nosolosw and others added 30 commits March 22, 2021 09:49
* Load editor assets by implementing should_load_block_editor_scripts_and_styles filter

* Add calls to do_action for enqueue_block_editor_assets

* Remove duplicate enqueue
* Fix query loop margin.

* Remove max-width.

* Remove query block max width

Co-authored-by: Riad Benguella <[email protected]>
* Themes: Translate custom templates in theme.json

* Rename preset to field in i18n handling for theme.json

* Add basic test for i18n support for custom templates in theme.json

* Refactor translate implementation in theme.json resolver class

* Refactor handling for template parts and custom templates

* Remove // phpcs:enable
* Fix PHPCS warnings

* cleanup unused params

* Add missing textdomain
Introduce a new `__unstableGetClientIdsTree` selector that doesn't rely on block attributes, wasting less re-renders.
* fix: ImageBlock reset size on external url change

* add bug fix to CHANGELOG.md

* E2E Test: Image Block should reset dimensions on URL change
)

Prevent the block toolbar from overlapping the navigation panel
and related template and content previews.
* dom: Split into smaller modules to facilitate typing

* Delete `dom.js`

* Fix isEmpty and update it to latest version
* api-fetch: Add types to media-upload middleware

* Remove runtime changes and denormalize return type

* Add descriptions to functions missing them
When a sidebar menu is opened on small screens, open the menu
on top of the editor content, rather than squishing the content.
This mainly applies to the widgets editor.
Automatically closes the navigation panel within the site editor
after selecting a template or content item.

Follow-up to #29489: it's particularly helpful on smaller screens,
where you would otherwise be left with the navigation panel taking up
most of the screen after making a selection.
* Expose Template part block variations to the Inserter

* remove explicit check for `area` block attribute
* enable listview, reorder items

* removes the hasListViewModal prop as it is not used anymore

Co-authored-by: Andrei Draganescu <[email protected]>
* Allow falling back to php templates

* inline doc

* Massaging var names - pros @draganescu

* Run phpcbf to fix PHP CS issues

* CS fix

* full-stop
* dom: Add types to `focusable`

* Fix incorrect param description

Co-authored-by: Marin Atanasov <[email protected]>

Co-authored-by: Marin Atanasov <[email protected]>
* Iterate on widget REST API endpoints

Makes the /wp/v2/widget and /wp/v2/widget-types endpoints:

- Work with widget instance attributes that cannot be serialized to JSON
- Less reliant on widget implementation details
- Work better with widgets that don't extend WP_Widget

* Fix phpunit failures

* Fix doc comment

* Fix batch requests and saving on Widgets screen

* Add tests to cover new functionality

* Support write-only form_data property instead of x-www-form-urlencoded

* Add /widget-types/:id/encode endpoint

* Delete unused WP_Option_Capturer

* Use hash_equals()

Co-authored-by: Timothy Jacobs <[email protected]>

* Use hash_equals()

Co-authored-by: Timothy Jacobs <[email protected]>

* Set show_instance_in_rest on all core widgets

* Treat classname the same way dynamic_sidebar() does

* Typo: Bock -> Block

* Remove unnecessary test code

* Add comment above call to _set

* Fix potential ->set() on null reference

* Clarify that form_data is URL-encoded

* DRY up repeated block HTML

* Use empty() to simplify show_instance_in_rest check

Co-authored-by: Timothy Jacobs <[email protected]>
* Add interface package

Implement interface

Add hacky useBlockSelectionClearer implementation

Toolbar tweaks

* Only show sidebar toggle on mobile

* Fix double BlockEditorProvider accidentally committed when resolving a merge conflict

* Adjust text

* Adjust content area to full-height, adjust padding to editor

* Remove duplicate shortcut elements, remove fragment

* Implement permanent sidebar area

* Hide bottom border on header

* Remove sidebar horizontal scroll

* Hide sidebar when creating first menu

* Fix test

* Move complementary area constants and move constants
jasmussen and others added 29 commits March 29, 2021 10:25
* Navigation: Fix arrow inheritance, polish

* Add in a margin fix.
* Show only the allowed patterns

* remove the early return from __experimentalGetAllowedPatterns

* revert block pattern fetched parsed blocks
…ized buttons (#29165)

* Try a columns-gap version of the buttons spacing implementation.

* Use width instead of flex basis.
I found an error in Usage example, useState is imported from the wrong package; @wordpress/element is the correct package instead of incorrect @wordpress/compose
If a core widget is unregistered then it will not be in
$wp_widgets_factory->widgets which causes a PHP warning.
* Control when screenreaders can access child components
* If the block is not currently selected, then the screenreaders ignore children. Once the block has been activated the user may then move between block components to update individual items.
* Add accessibility support to the search input field
* Add accessibility support for button and label
* Icon only button should not be accessible
* Update accessibility labels for consistency
* Use ‘text’ instead of ‘value’ for consistency
* Use a different message when no placeholder text is set
If a post type has no title support, then `ref.current` is
`undefined` and there is no `ownerDocument` to read nor title
to focus.
* Bump deployment target to iOS 13.0

* Bump react-native bridge and aztec deployment target to iOS 13.0

* Remove code specific to iOS versions before 13

* Update changelogs
* Fix toolbar for post excerpt block
* dom: Add types progressively to dom modules

* Add tests to assertIsDefined

* Try fix e2e

* Move defined assertion
@carolinan carolinan merged commit 3c90e05 into carolinan:add/post-comments-link Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.