style: update the use of LegacyKeyValueFormat in Dockerfiles #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossg
reviewed
Jul 22, 2024
timothystone-knsl
force-pushed
the
style/iss-legacy-key-value-format
branch
from
027468b to
d5cf7ce
Compare
|
FYI the |
|
I didn't see this feature in the |
carlossg
force-pushed
the
style/iss-legacy-key-value-format
branch
from
6f084ec to
d15fa0c
Compare
Per Docker [build-checks](https://docs.docker.com/reference/build-checks/legacy-key-value-format/): The correct format for declaring environment variables and build arguments in a Dockerfile is `ENV key=value` and `ARG key=value`, where the variable name (`key`) and value (`value`) are separated by an equals sign (`=`). Historically, Dockerfiles have also supported a space separator between the key and the value (for example, `ARG key value`). This legacy format is deprecated, and you should only use the format with the equals sign. This admonition does not mention `LABEL`, but it is included. Update the use of `LABEL` and `ENV` where necessary to remove deprecation warning. Fixes carlossg#486
carlossg
force-pushed
the
style/iss-legacy-key-value-format
branch
from
d15fa0c to
4c4581a
Compare
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Docker build-checks:
The correct format for declaring environment variables and build arguments in a Dockerfile is
ENV key=valueandARG key=value, where the variable name (key) and value (value) areseparated by an equals sign (
=). Historically, Dockerfiles have also supported a spaceseparator between the key and the value (for example,
ARG key value). This legacy format isdeprecated, and you should only use the format with the equals sign.
This admonition does not mention
LABEL, but it is included.Update the use of
LABELandENVwhere necessary to remove deprecation warning.Fixes #486