Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stethoscope 🩺 for Healthchecks (fixes #668) #667

Merged

Conversation

hf-kklein
Copy link
Contributor

@hf-kklein hf-kklein commented Dec 30, 2020

Description

Introduces the 🩺 :stethoscope: emoji for healthchecks. Discuss the need for this emoji in #668 .

Tests

  • All tests passed.

@vercel
Copy link

vercel bot commented Dec 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carloscuesta/gitmoji/ATL6PoA7FLKBPzAa2aZgGUpBai7A
✅ Preview: https://gitmoji-git-fork-hf-kklein-introducehealthc-beb550-carloscuesta.vercel.app

@hf-kklein hf-kklein mentioned this pull request Dec 30, 2020
@hf-kklein hf-kklein changed the title Add Stethoscope 🩺 for Healthchecks Add Stethoscope 🩺 for Healthchecks (fixes #668) Dec 30, 2020
@hf-kklein
Copy link
Contributor Author

I don't understand why the CI is failing. Happy for some advice.

@johannchopin
Copy link
Collaborator

@hf-kklein You need tu update the snapshots since you add a new element in the final html page. You can achieve it by using yarn jest -u.

Copy link
Collaborator

@johannchopin johannchopin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅ don't hesitate to rebase you branch on master.

@carloscuesta carloscuesta force-pushed the introduce_healthcheck_emoji branch from 14af0c1 to 32563bc Compare October 30, 2021 17:43
@carloscuesta carloscuesta merged commit bbad0e8 into carloscuesta:master Oct 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants