-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump action Node version to v20 #148
Bump action Node version to v20 #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, maintenance
Hey @LukasTy . Thank you for this. Sorry for the late reply. Do you mind rebase your PR and fix conflicts? And yes, there is no need to commit the output of the build command. |
Hey @carloscastrojumo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LukasTy . will release this.
Node 16 is deprecated on GitHub actions.
Running this action produces the following warning:
https://github.com/mui/mui-x/actions/runs/7956989267
Changes
using
tonode20
instead ofnode16
(other actions treated this change as a major release)BumpAlready done via a separate PR@types/node
to v20UpdateAlready done via a separate PR@actions/core
and@actions/io
to the latest versions@octokit/webhooks-definitions
with@octokit/webhooks-types
as the former is already deprecatedformat
Question
Do I need to
run build
and commit the updated built file or is release handled separately? 🤔