New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing repr(C) to WSABUF #26

Merged

carllerche merged 1 commit into carllerche:v0.1.x from EmbarkStudios:v0.1.x-repr-c-wsabuf

Oct 9, 2019

repi commented Oct 9, 2019

@lzutao caught this in the PR #25 review but has already been merged in then.


          Add missing repr(C) to WSABUF

0d925a1

Author

repi commented Oct 9, 2019

Without the repr(C) Rust (at least 1.38) did switch the order of the fields which makes the transmutes in the code not correct.

Think should yank 0.1.3 and publish a 0.1.4 with this.

Sorry that I missed it in the original PR :(

carllerche merged commit 837c18e into carllerche:v0.1.x

repi deleted the v0.1.x-repr-c-wsabuf branch

October 9, 2019 19:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet