Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding weather to recorder/replayer #5235

Closed
wants to merge 4 commits into from

Conversation

GustavoSilvera
Copy link

@GustavoSilvera GustavoSilvera commented Mar 7, 2022

Description

This change adds map weather events to the recorder to it can be reenacted just as it was recorded. This is useful to ensure the replay maintains the exact weather conditions during the recorded simulation. The implementation adds 1 event at the start of the recording to get the starting weather, then any calls to SetWeather (See Weather/Weather.cpp) with changed params will be added to the recorder as a one-time event.

I've tested recording, replaying, and querying. All work as expected.

Example line in the recorder query:

Weather events: 1
  Cloudiness: 61.76, Precipitation: 21.76, PrecipitationDeposits: 11.76, WindIntensity: 40.00, SunAzimuthAngle: 313.80, SunAltitudeAngle: 9.92, FogDensity: 11.76, FogDistance: 0.75, FogFalloff: 0.10, Wetness: 100.00, ScatteringIntensity: 1.00, MieScatteringScale: 0.03, RayleighScatteringScale: 0.03, 

Where has this been tested?

  • Platform(s): Linux (Ubuntu 20.04), Windows 10
  • Python version(s): 3.8 on Conda
  • Unreal Engine version(s): 4.26 (CarlaUnreal)

This change is Reviewable

@GustavoSilvera GustavoSilvera requested a review from a team as a code owner March 7, 2022 20:41
@update-docs
Copy link

update-docs bot commented Mar 7, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes.

@bernatx
Copy link
Contributor

bernatx commented Mar 9, 2022

Thanks for the PR.
We are working in making the recorder more deterministic (exact position of clouds and foliage animation,...), so we will check your changes to merge them.

@GustavoSilvera
Copy link
Author

Sounds good, hope it can be useful!

@stale
Copy link

stale bot commented Jun 1, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had recent activity label Jun 1, 2023
@stale stale bot closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue has not had recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants