Add opt --root-ceritificates & env BINSTALL_HTTPS_ROOT_CERTS
#820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
for specifying root ceritificates used for https connnections. And remove old environment variable `CARGO_HTTP_CAINFO`, `SSL_CERT_FILE` and `SSL_CERT_PATH` to avoid accidentally setting them, especially in CI env. Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
…certs Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
NobodyXu
changed the title
--root-ceritificates & env BINSTALL_HTTPS_ROOT_CERTS--root-ceritificates & env BINSTALL_HTTPS_ROOT_CERTS
passcod
reviewed
Feb 20, 2023
Co-authored-by: Félix Saparelli <[email protected]>
passcod
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for specifying root ceritificates used for https connnections.
And remove old environment variable
CARGO_HTTP_CAINFO,SSL_CERT_FILEand
SSL_CERT_PATHto avoid accidentally setting them, especially in CIenv.
Also:
binstalk_downloader::Certificate::from_envenvof depclapincrates/binfile-formatv0.14.0 tocrates/binfile-formatto determine pem/der file format when loading root certsbinstalk_downloader::Certificate::openand enumbinstalk_downloader::OpenCertificateErrorSigned-off-by: Jiahao XU [email protected]