Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt release workflow for workspace #331

Merged
merged 5 commits into from
Sep 4, 2022
Merged

Adapt release workflow for workspace #331

merged 5 commits into from
Sep 4, 2022

Conversation

passcod
Copy link
Member

@passcod passcod commented Sep 4, 2022 •
edited
Loading

Only create full releases for CLI so latest URLs still work.

CLI releases:

  • release PR has release notes section
  • tag with v1.2.3
  • make a release, with release notes from PR
  • build + upload

All other releases:

  • release PR has no release notes section
  • tag with crate-name-v1.2.3
  • do not make a release
  • no build

The PR also resets the versions of all crates except the CLI so they can be released properly. Versions to release (in this order):

  • detect-wasi 1.0.0
  • detect-targets 0.1.0
  • flock 0.1.0
  • normalize-path 0.1.0
  • lib 0.1.0
  • and finally bin 0.13.0!

@passcod
Adapt release for workspace
20fae4b 
Only create full releases for CLI so latest URLs still work.
@passcod passcod requested a review from NobodyXu September 4, 2022 10:29
NobodyXu
NobodyXu requested changes Sep 4, 2022
View reviewed changes
.github/workflows/release-pr.yml Outdated Show resolved Hide resolved
NobodyXu
NobodyXu approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@passcod passcod enabled auto-merge (squash) September 4, 2022 10:46
@passcod passcod merged commit e21617c into main Sep 4, 2022
@passcod passcod deleted the release-for-workspace branch September 4, 2022 11:12
@passcod passcod mentioned this pull request Sep 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@passcod @NobodyXu