-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new feature trust-dns
to lib & bin
#318
Conversation
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
I enabled |
I've started a release build for this PR https://github.com/cargo-bins/cargo-binstall/actions/runs/2917842935 to see how it affects binary size. |
If it's okay size wise we should just enable it by default, proper DNS resolution is the right thing to do, especially given the various issues with getaddrinfo |
I've run the CI on both main and this PR. The result is roughly 0.5M increase. P.S. it seems that the past PRs have caused the bin size to increase by 1-2M, might be worth investigation. |
Because the `getaddrinfo` is a poorly designed API. Signed-off-by: Jiahao XU <[email protected]>
Given that trust-dns only increase the binary size by 0.5M, I've enabled it by default. Though trust-dns only supports dns over https if rustls is used, thus the binaries built for windows does not have In the future, trust-dns will also support dns over quic (http3), which also only supports rustls. @passcod Shall we enable rustls feature on windows? |
I think so yes, that will also allow us to have consistent secure transport rules e.g. wintls not supporting 1.3 on some windows versions |
because wintls on the CI does not support TLS 1.3 and trust-dns only support dns over https if rustls is used. Signed-off-by: Jiahao XU <[email protected]>
Done! |
Note that this is before compression.
I was comparing size before compression vs size after compression. |
Hmm well, I think it's worth it for the feature set it adds. |
Signed-off-by: Jiahao XU [email protected]