-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Action declaration for installing cargo-binstall
#1269
Conversation
P.S. I prefer "rebase against main" instead of "merging from main into this PR", but since we are doing squash merge it won't matter anyway. If we are doing merge by commit, then the commit history would be a bit confusing. |
a904323
to
5a196e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm generally, just a few minor bits
CI failed due to 429 too many requests, once you update the PR I will approve and run the CI for you. |
It looks like it hung again. If the error is coming from let retry_policy = ExponentialBackoffBuilder::new()
.with_initial_interval(Duration::from_secs(1))
.with_max_interval(Duration::from_secs(16))
.with_multiplier(2.0)
.with_max_elapsed_time(Some(Duration::from_secs(300)))
.build();
let response = retry(retry_policy, || async {
match reqwest::get(&url).await {
Ok(response) => Ok(response),
Err(err) => Err(backoff::Error::transient(err)),
}
})
.await
.unwrap(); |
Thanks, but we already uses backoff there, I suspect it's because we submit too many PRs tonight. |
A good problem have |
Thank you @smallstepman ! |
Hmmm, I think you have just sent an incomplete comment. |
I was joking, I was referring to
|
Aha you mean "A good problem to have", now I get the joke |
ahhh, indeed I lost a few letters ^^ |
I'd like to suggest adding
action.yml
, which makes it easier for users to installcargo-binstall
in GitHub Action workflows, for example:see complete example here and the result of running that workflow.
I'm aware of https://github.com/taiki-e/install-action, but I'd prefer to: