feat: Verify cksum of crate tarball from cargo registry #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodyXu
force-pushed
the
feat/registry-checksum
branch
from
1d8343d to
466d3f0
Compare
passcod
reviewed
Aug 9, 2023
NobodyXu
force-pushed
the
feat/registry-checksum
branch
2 times, most recently
from
9f0c57d to
46f486b
Compare
passcod
approved these changes
Aug 9, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Fixed #1183 Since the crate tarball could be downloaded from a different set of servers than where the cargo registry is hosted, verifying the checksum is necessary to verify its integrity. Signed-off-by: Jiahao XU <[email protected]>
NobodyXu
force-pushed
the
feat/registry-checksum
branch
from
46f486b to
6d4c2c3
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1183
Since the crate tarball could be downloaded from a different set of servers than where the cargo registry is hosted, verifying the checksum is necessary to verify its integrity.