Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New install script compatibility with MacOS GHA runners #1254

Closed
max-sixty opened this issue Aug 6, 2023 · 1 comment · Fixed by #1263
Closed

New install script compatibility with MacOS GHA runners #1254

max-sixty opened this issue Aug 6, 2023 · 1 comment · Fixed by #1263

Comments

@max-sixty
Copy link

It seems that:

Would it make sense to use a different construction / offer a brew install for macs / suggest piping to zsh?

Thanks!
max-sixty added a commit to max-sixty/prql that referenced this issue Aug 6, 2023
@max-sixty
ci: Attempt to fix nightly workflow
c4e594c 
Based on cargo-bins/cargo-binstall#1254
@max-sixty max-sixty mentioned this issue Aug 6, 2023
Merged
@NobodyXu
Copy link
Member

NobodyXu commented Aug 7, 2023

Yes, we can replace if ! [[ -v CARGO_HOME ]] with if [[ -z "$CARGO_HOME" ]].
I welcome any PR for fixing this since I am a bit busy right now!

NobodyXu added a commit that referenced this issue Aug 9, 2023
@NobodyXu
Fix installation script on MacOS
4a37f2e 
Fixed #1254

and also add CI for installation script.

Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu NobodyXu mentioned this issue Aug 9, 2023
Merged
NobodyXu added a commit that referenced this issue Aug 9, 2023
@NobodyXu
Fix installation script on MacOS
cfe5158 
Fixed #1254

and also add CI for installation script and shellcheck.

Signed-off-by: Jiahao XU <[email protected]>
NobodyXu added a commit that referenced this issue Aug 9, 2023
@NobodyXu
Fix installation script on MacOS
5798e5b 
Fixed #1254

and also add CI for installation script and shellcheck.

Signed-off-by: Jiahao XU <[email protected]>
NobodyXu added a commit that referenced this issue Aug 9, 2023
@NobodyXu
Fix installation script on MacOS
2f7ac32 
Fixed #1254

and also add CI for installation script and shellcheck.

Signed-off-by: Jiahao XU <[email protected]>
NobodyXu added a commit that referenced this issue Aug 9, 2023
@NobodyXu
Fix installation script on MacOS
a3d05ad 
Fixed #1254

and also add CI for installation script and shellcheck.

Signed-off-by: Jiahao XU <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Aug 9, 2023
@NobodyXu
Fix installation script on MacOS (#1263)
1c886d8 
Fixed #1254

and also add CI for installation script and shellcheck.

Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu NobodyXu mentioned this issue Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix installation script on MacOS cargo-bins/cargo-binstall
2 participants
@max-sixty @NobodyXu