Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #14: popochiu-dev repo content has been merged in release repo #20

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

stickgrinder
Copy link
Collaborator

I took popochiu-dev repo main branch just before the merge of v1.9.0 features branch.
v1.9.0 should be ready to release. The automation is in place and checked (should be live tested on main).

I took everything in this repo:

  • additional addons (which are excluded form release, of course!)
  • popochiu test game (which we can change or move to a git submodule later, in the meantime it does its job)
  • I kept release repo readme files, of course, and added LEEME.md to the release automation

@mapedorr I didn't ported the .import folder, but maybe it's needed.

My suggestion is to review this MR, fix possible mistakes, squash and merge to main and test v1.9.0 release (possibly fixing problems on main directly).
Reverting a single squash commit if necessary will be easier.

…v1.9.0 ready to release, automations in place and checked.
@stickgrinder stickgrinder added the improvement New feature or request label Feb 2, 2023
@stickgrinder stickgrinder requested a review from mapedorr February 2, 2023 08:11
@stickgrinder stickgrinder self-assigned this Feb 2, 2023
@mapedorr
Copy link
Collaborator

mapedorr commented Feb 2, 2023

We don't need the .import files. Godot will create them for us.
I see everything in place.
I'm a risk person (in some scenarios) so I'll approve the PR.

Copy link
Collaborator

@mapedorr mapedorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is in place.

@mapedorr mapedorr merged commit 3bfc66d into main Feb 2, 2023
@stickgrinder stickgrinder deleted the feature/14-one-dev-repo branch February 4, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants