Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #147: Docs are deployed with every new release + Release should now work again #174

Merged
merged 7 commits into from
Mar 17, 2024

Conversation

stickgrinder
Copy link
Collaborator

This PR completes the Popochiu 2.0 documentation framework, adding a GitHub action that starts alongside the "New release" one.

I also added a first commit with a permission fix that should bring back the release workflow (it was broken).

I tested:

  • That the deploy via GH Actions works as intended. It does.
  • That we can still use the make docs-deploy from any branch and it does not clash with the GH Actions WF. Everything seems ok.

I didn't test:

  • If the release WF is actually working again. We have to push a v2.0-beta2 tag for that. But it should be ok now since I clearly identified the root cause.

@stickgrinder stickgrinder added documentation Improvements or additions to documentation improvement New feature or request labels Mar 17, 2024
@stickgrinder stickgrinder added this to the v2.0 - Stable milestone Mar 17, 2024
@stickgrinder stickgrinder requested a review from mapedorr March 17, 2024 11:14
@stickgrinder stickgrinder self-assigned this Mar 17, 2024
Copy link
Collaborator

@mapedorr mapedorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll test this with the release of beta 2.

@mapedorr mapedorr merged commit 83aea56 into develop Mar 17, 2024
@mapedorr mapedorr deleted the feature/147-docs-release-automation branch March 17, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants