Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'New File' button in code submode #797

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Conversation

burieberry
Copy link
Contributor

Ended up using the BoxelDropdown component with Boxel Button and Menu components. Small refactor of code mode top bar.

new-file-btn-menu-open new-file-button

@burieberry burieberry requested a review from a team November 6, 2023 20:02
@burieberry burieberry changed the title Add new file button in code submode Add 'New File' button in code submode Nov 6, 2023
Copy link

github-actions bot commented Nov 6, 2023

Test Results

418 tests  ±0   414 ✔️ ±0   6m 22s ⏱️ + 1m 36s
    1 suites ±0       4 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 3c9de79. ± Comparison against base commit 8cec704.

♻️ This comment has been updated with latest results.

@burieberry burieberry force-pushed the cs-6203-add-new-file-button branch from 5a314f5 to 1228dbe Compare November 6, 2023 20:16
@burieberry burieberry requested a review from lukemelia November 6, 2023 21:16
@burieberry burieberry force-pushed the cs-6203-add-new-file-button branch from 2c07e61 to baf821e Compare November 6, 2023 21:18
@burieberry burieberry force-pushed the cs-6203-add-new-file-button branch from baf821e to 082981b Compare November 6, 2023 21:19
@burieberry burieberry merged commit 171dfb2 into main Nov 7, 2023
19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cs-6203-add-new-file-button branch November 7, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants