Review card subclass of BlogPost card #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burieberry
commented
Dec 13, 2024
Comment on lines
+10
to
+12
| // @ts-expect-error using own template | ||
| export class Review extends BlogPost { |
There was a problem hiding this comment.
Extending a card def and changing one of its templates gives error about "incorrectly extending BlogPost class" "types of property 'isolated' are incompatible"
burieberry
force-pushed
the
cs-7544-review-card
branch
from
576a594 to
b12c0a0
Compare
burieberry
commented
Dec 17, 2024
| @@ -267,21 +268,19 @@ class BlogAppTemplate extends Component<typeof BlogApp> { | |||
| </:contentHeader> | |||
| <:grid> | |||
| {{#if this.query}} | |||
| <div class='content-scroll-container'> | |||
There was a problem hiding this comment.
Removed duplicate scroll-container div (already exists in CardsGrid component)
burieberry
commented
Dec 17, 2024
| @@ -225,6 +225,7 @@ class BlogAppTemplate extends Component<typeof BlogApp> { | |||
| @title={{or @model.title ''}} | |||
| @tagline={{or @model.description ''}} | |||
| @thumbnailURL={{or @model.thumbnailURL ''}} | |||
| @icon={{@model.constructor.icon}} | |||
There was a problem hiding this comment.
option to display card type icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RatingsSummaryfield: now it can display half starsReviewBlog instance with embedded Review card:
Review card isolated template:
