-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set browser tab title based on stack item #1803
Set browser tab title based on stack item #1803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well so the challenge is that in code mode specifically you don't always have a title. consider a card that has a bug in its card def. neither it nor any of its instances will be runnable--what would the title of the window be? what about files that are not instances nor card field field--like an arbitrary .TS file? i think there are many circumstances where is just not clear what to use for a title in code mode aside from the code path of the file you are editing |
It might be better to use "[path] in [Workspace Name]". i.e. "AIAppGenerator/commands.ts in Experiments" Less URL-like, but communicates effectively. |
fixed in d0d1f81 |
This PR sets the browser tab title and history item based on the title of the top most card of the right stack. As well as, it also sets the browser tab title based on the file displayed in code mode.