Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set browser tab title based on stack item #1803

Merged

Conversation

habdelra
Copy link
Contributor

@habdelra habdelra commented Nov 15, 2024

This PR sets the browser tab title and history item based on the title of the top most card of the right stack. As well as, it also sets the browser tab title based on the file displayed in code mode.

title

Copy link

github-actions bot commented Nov 15, 2024

Host Test Results

    1 files  ±0      1 suites  ±0   19m 23s ⏱️ +13s
680 tests +1  679 ✔️ +1  1 💤 ±0  0 ±0 
685 runs  +1  684 ✔️ +1  1 💤 ±0  0 ±0 

Results for commit d0d1f81. ± Comparison against base commit db8c1b1.

♻️ This comment has been updated with latest results.

@habdelra habdelra requested a review from a team November 15, 2024 20:36
Copy link
Contributor

@jurgenwerk jurgenwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it's a bit odd to see URLs in the titles

Screenshot from your video:
image

I'd prefer the following nomenclature for titles

Hello World (Code mode)
Experiments Workspace
Argentina
Argentina (Code mode)
...

Not sure if this was already discussed, just saying my opinion, otherwise LGTM!

@jurgenwerk jurgenwerk requested a review from a team November 18, 2024 08:55
@habdelra
Copy link
Contributor Author

habdelra commented Nov 18, 2024

To me it's a bit odd to see URLs in the titles

Screenshot from your video: image

I'd prefer the following nomenclature for titles

Hello World (Code mode) Experiments Workspace Argentina Argentina (Code mode) ...

Not sure if this was already discussed, just saying my opinion, otherwise LGTM!

well so the challenge is that in code mode specifically you don't always have a title. consider a card that has a bug in its card def. neither it nor any of its instances will be runnable--what would the title of the window be? what about files that are not instances nor card field field--like an arbitrary .TS file? i think there are many circumstances where is just not clear what to use for a title in code mode aside from the code path of the file you are editing

@lukemelia
Copy link
Contributor

well so the challenge is that in code mode specifically you don't always have a title. consider a card that has a bug in its card def. neither it nor any of its instances will be runnable--what would the title of the window be? what about files that are not instances nor card field field--like an arbitrary .TS file? i think there are many circumstances where is just not clear what to use for a title in code mode aside from the code path of the file you are editing

It might be better to use "[path] in [Workspace Name]". i.e. "AIAppGenerator/commands.ts in Experiments" Less URL-like, but communicates effectively.

@habdelra
Copy link
Contributor Author

well so the challenge is that in code mode specifically you don't always have a title. consider a card that has a bug in its card def. neither it nor any of its instances will be runnable--what would the title of the window be? what about files that are not instances nor card field field--like an arbitrary .TS file? i think there are many circumstances where is just not clear what to use for a title in code mode aside from the code path of the file you are editing

It might be better to use "[path] in [Workspace Name]". i.e. "AIAppGenerator/commands.ts in Experiments" Less URL-like, but communicates effectively.

fixed in d0d1f81

@habdelra habdelra merged commit 5172301 into main Nov 19, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants