Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use decorator-transforms in card transpilation toolchain #1771

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Nov 8, 2024

  • First we're switching to decorator-transforms. We were already using it for host cost, now cards use it too. I'm switching the runtime from importable to globals because it's easier to make that work portably in the realm server, outside fastboot.
  • Next: replace ember-template-imports preprocessor with content-tag. This fixes a whole bunch of bugs in gjs parsing. This can be a separate PR, since this one is green and ready to merge.

First we're switching to decorator-transforms.  We were already using it for host cost, now cards use it too. I'm switching the runtime from importable to globals because it's easier to make that work portably in the realm server, outside fastboot.
Copy link

github-actions bot commented Nov 8, 2024

Host Test Results

    1 files  ±0      1 suites  ±0   19m 27s ⏱️ - 1m 24s
679 tests ±0  678 ✔️ ±0  1 💤 ±0  0 ±0 
684 runs  ±0  683 ✔️ ±0  1 💤 ±0  0 ±0 

Results for commit 1ba2196. ± Comparison against base commit a7d4a87.

♻️ This comment has been updated with latest results.

@ef4 ef4 marked this pull request as ready for review November 13, 2024 22:29
@ef4 ef4 changed the title Updating card transpilation toolchain Use decorator-transforms in card transpilation toolchain Nov 13, 2024
@ef4 ef4 merged commit 97c8551 into main Nov 13, 2024
37 checks passed
@ef4 ef4 mentioned this pull request Nov 13, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant