Enhance multi-select for usage inside applications #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tintinthong
commented
Oct 29, 2024
•
tintinthong
commented
- unify styles of multi select and select
- give caret dropdown toggle up and down. Previously, it just pointed down
- yield option from custom trigger back to the consumer. All custom components. triggerComponent, selectedItemComponent
tintinthong
changed the title
tintinthong
changed the title
lucaslyl
reviewed
Oct 29, 2024
lucaslyl
reviewed
Oct 29, 2024
lucaslyl
reviewed
Oct 29, 2024
packages/boxel-ui/addon/src/components/multi-select/selected-item.gts
Outdated
Show resolved
Hide resolved
packages/boxel-ui/addon/src/components/multi-select/selected-item.gts
Outdated
Show resolved
Hide resolved
packages/boxel-ui/addon/src/components/multi-select/trigger.gts
Outdated
Show resolved
Hide resolved
packages/boxel-ui/addon/src/components/multi-select/trigger.gts
Outdated
Show resolved
Hide resolved
burieberry
reviewed
Oct 30, 2024
packages/boxel-ui/addon/src/components/multi-select/selected-item.gts
Outdated
Show resolved
Hide resolved
packages/boxel-ui/addon/src/components/multi-select/trigger.gts
Outdated
Show resolved
Hide resolved
packages/boxel-ui/addon/src/components/multi-select/trigger.gts
Outdated
Show resolved
Hide resolved
packages/boxel-ui/addon/src/components/multi-select/trigger.gts
Outdated
Show resolved
Hide resolved
packages/boxel-ui/addon/src/components/multi-select/trigger.gts
Outdated
Show resolved
Hide resolved
tintinthong
changed the title
burieberry
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.