Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-template-imports to 4.1.1 #1305

Merged
merged 3 commits into from
May 29, 2024
+55 −60
Merged

Update ember-template-imports to 4.1.1 #1305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec6ce12
Update ember-template-imports to 4.1.1
backspace May 28, 2024
ebae60a
Change how test context type is specified
backspace May 28, 2024
a3915c2
Merge branch 'main' into eti-hax
backspace May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"ember-cli-htmlbars": "^6.3.0",
"ember-resources": "^6.3.1",
"ember-source": "~5.4.0",
"ember-template-imports": "^3.0.1",
"ember-template-imports": "^4.1.1",
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.4.0",
"eslint-plugin-import": "^2.26.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/boxel-motion/addon/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"babel-plugin-ember-template-compilation": "^2.2.1",
"concurrently": "^8.0.1",
"ember-source": "~5.4.0",
"ember-template-imports": "^3.1.2",
"ember-template-imports": "^4.1.1",
"ember-template-lint": "^5.11.2",
"ember-template-lint-plugin-prettier": "^5.0.0",
"eslint": "^8.31.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/boxel-motion/test-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"ember-resources": "^6.3.1",
"ember-source": "^5.4.0",
"ember-source-channel-url": "^3.0.0",
"ember-template-imports": "^3.0.1",
"ember-template-imports": "^4.1.1",
"ember-template-lint": "^5.11.2",
"ember-try": "^2.0.0",
"eslint": "^8.52.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/boxel-ui/addon/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"babel-plugin-ember-template-compilation": "^2.2.1",
"concurrently": "^8.0.1",
"ember-concurrency": "^4.0.1",
"ember-template-imports": "^3.1.2",
"ember-template-imports": "^4.1.1",
"ember-template-lint": "^5.11.2",
"ember-template-lint-plugin-prettier": "^5.0.0",
"eslint": "^8.31.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/boxel-ui/test-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"ember-resources": "^6.3.1",
"ember-source": "^5.4.0",
"ember-source-channel-url": "^3.0.0",
"ember-template-imports": "^3.1.2",
"ember-template-imports": "^4.1.1",
"ember-template-lint": "^5.11.2",
"ember-try": "^2.0.0",
"eslint": "^8.52.0",
Expand Down
22 changes: 11 additions & 11 deletions packages/boxel-ui/test-app/tests/integration/components/resizable-panel-group-test.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,15 +135,15 @@ module('Integration | ResizablePanelGroup', function (hooks) {
await sleep(100); // let didResizeModifier run
}

test('it can lay out panels vertically (default)', async function (this: MyTestContext, assert) {
test<MyTestContext>('it can lay out panels vertically (default)', async function (assert) {
this.renderController.containerStyle =
'max-height: 100%; width: 100px; height: 318px;';
await renderVerticalResizablePanelGroup(this.renderController);
assert.hasNumericStyle('.panel-0-content', 'height', 300 * 0.6, 1);
assert.hasNumericStyle('.panel-1-content', 'height', 300 * 0.4, 1);
});

test('it can lay out panels vertically (length specified)', async function (this: MyTestContext, assert) {
test<MyTestContext>('it can lay out panels vertically (length specified)', async function (assert) {
this.renderController.containerStyle =
'max-height: 100%; width: 200px; height: 518px; border: 1px solid green';
this.renderController.panels[0].lengthPx = 355;
Expand All @@ -153,15 +153,15 @@ module('Integration | ResizablePanelGroup', function (hooks) {
assert.hasNumericStyle('.panel-1-content', 'height', 143, 1);
});

test('it respects vertical minLength (default)', async function (this: MyTestContext, assert) {
test<MyTestContext>('it respects vertical minLength (default)', async function (assert) {
this.renderController.containerStyle =
'max-height: 100%; width: 200px; height: 108px;';
await renderVerticalResizablePanelGroup(this.renderController);
assert.hasNumericStyle('.panel-0-content', 'height', 40, 1);
assert.hasNumericStyle('.panel-1-content', 'height', 50, 1);
});

test('it respects vertical minLength (length specified)', async function (this: MyTestContext, assert) {
test<MyTestContext>('it respects vertical minLength (length specified)', async function (assert) {
this.renderController.containerStyle =
'max-height: 100%; width: 200px; height: 108px; border: 1px solid green';
this.renderController.panels[0].lengthPx = 45;
Expand All @@ -171,7 +171,7 @@ module('Integration | ResizablePanelGroup', function (hooks) {
assert.hasNumericStyle('.panel-1-content', 'height', 50, 2);
});

test('it adjusts to its container growing (default)', async function (this: MyTestContext, assert) {
test<MyTestContext>('it adjusts to its container growing (default)', async function (assert) {
this.renderController.containerStyle =
'max-height: 100%; width: 200px; height: 218px;';
await renderVerticalResizablePanelGroup(this.renderController);
Expand All @@ -182,7 +182,7 @@ module('Integration | ResizablePanelGroup', function (hooks) {
assert.hasNumericStyle('.panel-1-content', 'height', 160, 1);
});

test('it adjusts to its container growing (length specified)', async function (this: MyTestContext, assert) {
test<MyTestContext>('it adjusts to its container growing (length specified)', async function (assert) {
this.renderController.containerStyle =
'max-height: 100%; width: 200px; height: 218px; border: 1px solid green';
this.renderController.panels[0].lengthPx = 100;
Expand All @@ -197,7 +197,7 @@ module('Integration | ResizablePanelGroup', function (hooks) {
assert.hasNumericStyle('.panel-1-content', 'height', 200, 1.5);
});

test('it adjusts to its container shrinking (default)', async function (this: MyTestContext, assert) {
test<MyTestContext>('it adjusts to its container shrinking (default)', async function (assert) {
this.renderController.containerStyle =
'max-height: 100%; width: 200px; height: 418px;';
await renderVerticalResizablePanelGroup(this.renderController);
Expand All @@ -208,7 +208,7 @@ module('Integration | ResizablePanelGroup', function (hooks) {
assert.hasNumericStyle('.panel-1-content', 'height', 80, 1);
});

test('it adjusts to its container shrinking (length specified A)', async function (this: MyTestContext, assert) {
test<MyTestContext>('it adjusts to its container shrinking (length specified A)', async function (assert) {
this.renderController.containerStyle =
'max-height: 100%; width: 200px; height: 420px; border: 1px solid green';
// Height ratio panel 1 and panel 2 is 3:2
Expand All @@ -225,7 +225,7 @@ module('Integration | ResizablePanelGroup', function (hooks) {
assert.hasNumericStyle('.panel-1-content', 'height', 80, 1);
});

test('it adjusts to its container shrinking (length specified B)', async function (this: MyTestContext, assert) {
test<MyTestContext>('it adjusts to its container shrinking (length specified B)', async function (assert) {
this.renderController.containerStyle =
'max-height: 100%; width: 200px; height: 620px; border: 1px solid green';
// Height ratio panel 1 and panel 2 is 2:1
Expand All @@ -244,7 +244,7 @@ module('Integration | ResizablePanelGroup', function (hooks) {
assert.hasNumericStyle('.panel-1-content', 'height', 67, 1);
});

test('it adjusts to its container shrinking and growing', async function (this: MyTestContext, assert) {
test<MyTestContext>('it adjusts to its container shrinking and growing', async function (assert) {
this.renderController.containerStyle =
'max-height: 100%; width: 200px; height: 620px; border: 1px solid green';
this.renderController.panels[0].lengthPx = 400;
Expand Down Expand Up @@ -276,7 +276,7 @@ module('Integration | ResizablePanelGroup', function (hooks) {
assert.hasNumericStyle('.panel-1-content', 'height', 240, 1);
});

test('it excludes hidden panels from participating in layout', async function (this: MyTestContext, assert) {
test<MyTestContext>('it excludes hidden panels from participating in layout', async function (assert) {
this.renderController.containerStyle =
'max-height: 100%; width: 200px; height: 218px;';
this.renderController.panels = [
Expand Down
2 changes: 1 addition & 1 deletion packages/host/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
"ember-resources": "^6.3.1",
"ember-route-template": "^1.0.3",
"ember-source": "~5.4.0",
"ember-template-imports": "^3.0.1",
"ember-template-imports": "^4.1.1",
"ember-template-lint": "^5.11.2",
"ember-test-selectors": "^6.0.0",
"ember-velcro": "^2.1.3",
Expand Down
81 changes: 38 additions & 43 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.