Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Fix widths of icons in Freestyle #1161

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Apr 11, 2024

The border needs to be included in the container width.

This fixes a problem in #1159 which made us believe the icons were exceeding their viewboxes. See the preview here.

Before:

screencast 2024-04-11 11-04-34

After:

Boxel Components 2024-04-11 14-24-11

@backspace backspace added the bug Something isn't working label Apr 11, 2024
@backspace backspace self-assigned this Apr 11, 2024
Copy link

github-actions bot commented Apr 11, 2024

Test Results

584 tests  ±0   580 ✔️ ±0   8m 17s ⏱️ - 1m 19s
    1 suites ±0       4 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 0783631. ± Comparison against base commit 0fc8f68.

♻️ This comment has been updated with latest results.

@backspace backspace requested a review from a team April 11, 2024 19:45
@backspace backspace marked this pull request as ready for review April 11, 2024 19:45
The border needs to be included in the container width.
@backspace backspace force-pushed the ui/icons-border-calc-cs-6700 branch from ab13004 to 0783631 Compare April 11, 2024 20:00
@backspace backspace merged commit 563cc3a into main Apr 12, 2024
17 checks passed
@delete-merged-branch delete-merged-branch bot deleted the ui/icons-border-calc-cs-6700 branch April 12, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants