Cs 6642 resizable panel id undefined #1153

tintinthong · 2024-04-10T06:26:41Z

We get a situation when a panel isHidden, the html div id is undefined.

Currently, registration of a panel works like this (its bcos we use a modifier)

the panel puts a div with an undefined id
the panel group then mutates the div with the defined id during registration
its the same the other way, when we toggle a panel to be hidden, the placeholder element will have its id removed. This is bcos registration of a panel is toggled with isHidden arg.

I propose we just stop unregistering via a modifier that is toggled by @isHidden arg

github-actions · 2024-04-10T06:41:09Z

Test Results

584 tests ±0 580 ✔️ ±0 8m 36s ⏱️ ±0s
    1 suites ±0     4 💤 ±0
    1 files ±0     0 ❌ ±0

Results for commit 404416e. ± Comparison against base commit fe40346.

♻️ This comment has been updated with latest results.

tintinthong · 2024-04-10T07:15:38Z

packages/boxel-ui/test-app/tests/integration/components/resizable-panel-group-test.gts

+    assert.hasNumericStyle('.panel-0-content', 'height', 168, 1);
+    assert.hasNumericStyle('.panel-1-content', 'height', 50, 1);


Its not clear to me why this changed

tintinthong added 3 commits April 10, 2024 14:19

Fix id of undefined

4189a9b

remove debugger

0b26090

remove the getter which is completely unused

4d421a2

tintinthong added 2 commits April 10, 2024 14:41

Fix test

6be8381

fix lint

404416e

tintinthong commented Apr 10, 2024

View reviewed changes

tintinthong requested a review from a team April 10, 2024 07:15

lukemelia approved these changes Apr 10, 2024

View reviewed changes

tintinthong merged commit 996fd15 into main Apr 11, 2024
16 checks passed

		assert.hasNumericStyle('.panel-0-content', 'height', 168, 1);
		assert.hasNumericStyle('.panel-1-content', 'height', 50, 1);