Update marked package #1116
Merged
Update marked package #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemelia
reviewed
Mar 25, 2024
packages/base/markdown.gts
Outdated
| function toHtml(markdown: string | null) { | ||
| return markdown ? sanitizeHtml(marked(markdown, markdownOpts)) : ''; | ||
| return markdown ? sanitizeHtml(marked(markdown) as string) : ''; |
There was a problem hiding this comment.
Why do we have to cast this? What type does TypeScript think it is?
There was a problem hiding this comment.
return type says string | Promise<string>
There was a problem hiding this comment.
I'm curious why it might be a promise. sounds like there is a potential we might be leaking async here unless we await...
There was a problem hiding this comment.
I think it's only async if the options are set to be { async: true } or if any of the options return async. Here's what the docs say: https://marked.js.org/using_pro#async
Here are the signatures:
Thoughts? Just setting the async options to explicitly be false didn't work for glint.
There was a problem hiding this comment.
lukemelia
reviewed
Mar 28, 2024
lukemelia
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated options were causing a lot of warning messages.