Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

motion: Add deployments #1110

Merged
merged 13 commits into from
Mar 27, 2024
Merged

motion: Add deployments #1110

merged 13 commits into from
Mar 27, 2024

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Mar 21, 2024

This is #1109 for boxel-motion.

@backspace backspace added the enhancement New feature or request label Mar 21, 2024
@backspace backspace self-assigned this Mar 21, 2024
Copy link

github-actions bot commented Mar 21, 2024

Test Results

538 tests  ±0   534 ✔️ ±0   7m 58s ⏱️ -1s
    1 suites ±0       4 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 814f455. ± Comparison against base commit 2acaf3e.

♻️ This comment has been updated with latest results.

@backspace backspace marked this pull request as ready for review March 22, 2024 20:37
@backspace backspace requested a review from a team March 22, 2024 20:37
uses: ./.github/actions/deploy-ember-preview
env:
S3_PREVIEW_BUCKET_NAME: boxel-motion-preview.cardstack.com
AWS_S3_BUCKET: boxel-motion-preview.cardstack.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as infra PR about whether to use this domain

Copy link
Contributor

@lukemelia lukemelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides domain question

# Conflicts:
#	.github/workflows/manual-deploy.yml
#	package.json
#	packages/boxel-motion/test-app/package.json
#	pnpm-lock.yaml
@backspace backspace merged commit ae355eb into main Mar 27, 2024
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the motion/deploy-cs-6635 branch March 27, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants