Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host: Fix deployed read-only code mode tooltips #1048

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

backspace
Copy link
Contributor

@backspace backspace commented Feb 20, 2024

I accomplished #1039 using CSS nesting which I thought was safe to use but something in the build pipeline was stripping it out, resulting in an unfortunate mix of styles:

StatusIndicator 2024-02-20 15-47-11

This flattens out the nesting at the expense of lengthy selectors, but it works!

Boxel 2024-02-20 17-29-34

@backspace backspace added the bug Something isn't working label Feb 20, 2024
@backspace backspace self-assigned this Feb 20, 2024
Copy link

Test Results

518 tests  ±0   514 ✔️ ±0   7m 1s ⏱️ +6s
    1 suites ±0       4 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 6b00cdc. ± Comparison against base commit e3de0c2.

@backspace backspace marked this pull request as ready for review February 20, 2024 23:27
@backspace backspace requested a review from a team February 20, 2024 23:30
@backspace backspace merged commit d4188f2 into main Feb 21, 2024
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the host/read-only-tooltip-style-cs-6577 branch February 21, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants