Realm dropdown shows only readable realms #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…down. provide realm dropdown default fallbacks
habdelra
commented
Feb 16, 2024
| @@ -94,7 +94,7 @@ export class RealmAuthClient { | |||
| } | |||
|
|
|||
| private async initiateSessionRequest() { | |||
| return fetch(`${this.realmURL.href}_session`, { | |||
| return this.loader.fetch(`${this.realmURL.href}_session`, { | |||
There was a problem hiding this comment.
this was necessary in order to perform resolution on the https://cardstack.com/base URL. in general we should always be using the loader's fetch.
habdelra
commented
Feb 16, 2024
| @@ -106,7 +106,7 @@ export class RealmAuthClient { | |||
| } | |||
|
|
|||
| private async challengeRequest(challenge: string) { | |||
| return fetch(`${this.realmURL.href}_session`, { | |||
| return this.loader.fetch(`${this.realmURL.href}_session`, { | |||
habdelra
requested review from
backspace,
IanCal,
jurgenwerk,
tintinthong,
FadhlanR and
burieberry
FadhlanR
approved these changes
Feb 20, 2024
…pector-inherit-create-and-duplicate-instance
delete-merged-branch
bot
deleted the
cs-6381-code-mode-inspector-inherit-create-and-duplicate-instance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we make the base realm a read-only realm. The realm drop down is updated to only show writable realms. We also provide a default realm menu item fallbacks for the case when the current realm is a read-only realm.
TODO: