Move title to card pill component (#1147)

cardstack · Apr 6, 2024 · 86f0516 · 86f0516
1 parent 3bbcd1b
commit 86f0516
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/packages/base/field-component.gts b/packages/base/field-component.gts
@@ -94,10 +94,6 @@ export function getBoxComponent(
     };
   }
 
-  function title(cardOrField: BaseDef, format: Format) {
-    return isCard(cardOrField) && format === 'atom' ? cardOrField.title : '';
-  }
-
   let component: TemplateOnlyComponent<{
     Args: { format?: Format; displayContainer?: boolean };
   }> = <template>
@@ -116,7 +112,6 @@ export function getBoxComponent(
             fieldType=field.fieldType
             fieldName=field.name
           }}
-          title={{title model.value f.format}}
           data-test-card-format={{f.format}}
           data-test-field-component-card
           {{! @glint-ignore  Argument of type 'unknown' is not assignable to parameter of type 'Element'}}

diff --git a/packages/host/app/components/card-pill.gts b/packages/host/app/components/card-pill.gts
@@ -46,7 +46,7 @@ export default class CardPill extends Component<CardPillSignature> {
         </RealmInfoProvider>
       </:icon>
       <:default>
-        <div class='card-content'>
+        <div class='card-content' title={{@card.title}}>
           <this.component @displayContainer={{false}} />
         </div>
         {{#if @removeCard}}