-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0036 | Adding the deregistration metadata format #349
Conversation
gitmachtl
commented
Oct 8, 2022
•
edited
Loading
edited
- Adding the deregistration metadata format to the README.md and the schema.cddl
- The deregistration metadata uses the key 61286 and is independent from the registration metadata which uses key 61284
- Updating CIP-0010 (metadata datum registry), description for key 61285(witness) and 61286(deregistration)
please everybody see, for prior discussion: |
so, this should now be the final PR hopefully 😄 |
Yes
Technically, this is specific to Catalyst voting on the corresponding Jormungandr voting chains (it is possible that purpose 0 might also be collated and used by a third party, for example, as a generic/non-specific vote delegation). |
The main reason for not wanting to use eg an empty delegation array or second metadata format for deregistration purposes is that this creates complication for hardware wallets (perhaps two apps are needed). |
There is no need imo that hardware wallets have to support all features, thats why i wrote the line: I don't see a problem if deregistraton would not be supported on hardware wallets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The main reason for not wanting to use eg an empty delegation array or second metadata format for deregistration purposes is that this creates complication for hardware wallets (perhaps two apps are needed).
may be good to give a rationale for this in the CIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense 👍 @gitmachtl are you ready for this to be merged?
OK, this all seems in order then 😎 |