-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0013 update #130
CIP-0013 update #130
Conversation
@tomislavhoracek there are a number of problems with including this specific suggestion as an addition to this generally oriented CIP, rather than as a separate CIP or even simply a feature request for Daedalus: When I proposed stake pool links as a standard about 1 year ago, after first writing my own CIP (#25) I was then advised by @SebastienGllmt to add the stake pool links to the already existing CIP-0013 covering payment links, and to refactor my proposal & pull request accordingly. In hindsight this has been a mistake since there are likely to be many URI protocol, authority and query extensions and we don't want to be adding them all in a single document which would end up having hundreds of pages and authors. @v-almonacid suggested a good way around this, which may be the only way a general Cardano URI Scheme would be supportable in the long run: breaking all relevant CIP's (including CIP-0013 itself) into separate proposal documents each covering their own part of the URI namespace, as suggested & described here:
Pending the serious discussion of this strategy that still needs to take place, I would recommend you do both the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that's unclear to me from the text is the purpose of this Daedalus specific extension. What is the purpose? Can we include that motivation in the text? I think that would benefit other readers, not just CIP editors.
We've progressed the idea of having a new "URI framework CIP" — which would allow proposals like this to be submitted separately as their own CIPs on top of that framework — at today's CIP meeting, from which a tentative plan emerged which I've documented here: https://forum.cardano.org/t/cip-generalized-cardano-urls/57464/5 |
Examples: | ||
|
||
Daeadalus Mainnet = web+daedalus-mainnet | ||
Daeadalus Flight = web+daedalus-mainnet_flight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want the choice of "mainnet vs mainnet flight" to be made by the links themselves, rather than by the users?
E.g. if I only have Daedalus Flight installed, urls I find online with web+daedalus-mainnet://
wouldn't work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E.g. if I only have Daedalus Flight installed, urls I find online with web+daedalus-mainnet:// wouldn't work?
Correct. Every application needs to have a dedicated URL schema. There is no other way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want the choice of "mainnet vs mainnet flight" to be made by the links themselves, rather than by the users?
The network param would be used to preselect the correct application.
E.g. mainnet could be open up by Daedalus Mainnet, Daedalus Flight, Yoroi, AdaLite, etc.
I see Plutus apps offering users to chose themselves, but the network URL param preselects the default one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buh ah, the web+cardano:://
prefix, however, would work with any wallet you have installed? (where I guess it might be undefined which wallet opens if you have several?)
But where users, e.g. through PAB, also have the opportunity to specify the exactly wallet/app they want to use, through the other prefixes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
web+cardano:://
would open one of the installed ones. It is not possible to explicitly know which one. It depends on the platform, the order in which different wallets were installed, etc.
We want to introduce the Daedalus specific handlers in order to handle different networks and in order to be able to explicitly open Daedalus.
Add balance-tx scheme
We've tentatively resolved at the CIP meeting today, based on precedent with the many PR's against dApp Connector CIP-0030 (https://github.com/cardano-foundation/CIPs/tree/master/CIP-0030), for future Cardano URI Scheme extensions to be added as separate CIP's rather than updates to CIP-0013 (see also Cardano Forum post). Therefore if the authors are still pursuing this PR, it should be refactored as its own new CIP, referring to CIP-0013 rather than modifying it. In either case this PR should be closed & of course we hope to hear feedback from the author(s) 😎 |
@tomislavhoracek @nikolaglumac Is this one still relevant or shall we close the PR? |
@tomislavhoracek @nikolaglumac closing due to apparently defunct status. |
This PR introduces a CIP-0013 update where "Handling Daedalus specific links" section is added as well as "Transaction balancing and signing URI queries" draft section.