Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0006 social contacts #142

Closed
mkazlauskas opened this issue Oct 22, 2021 · 4 comments · Fixed by #156
Closed

CIP-0006 social contacts #142

mkazlauskas opened this issue Oct 22, 2021 · 4 comments · Fixed by #156

Comments

@mkazlauskas
Copy link

JSON schema 'contact' has all social accounts required. This means you can't set contacts without having every social account listed in schema. This is not sustainable as some platforms will die in the future.

Question: schema in master branch is different from the one in cips.cardano.org. Which one is the most up-to-date?

@papacarp @gufmar

@rhyslbw
Copy link
Contributor

rhyslbw commented Nov 23, 2021

@crptmppt can you please advise on this:

Question: schema in master branch is different from the one in cips.cardano.org. Which one is the most up-to-date?

We'll create an amendment proposal if wishing to pursue the primary issue further @mkazlauskas

@crptmppt
Copy link
Contributor

@rhyslbw the autogen site builds from the github, it seems strange that it would be out of sync. In case of conflicts, check the Github page

@KtorZ
Copy link
Member

KtorZ commented Nov 23, 2021

The problem is that the schema.json file does not match the schema given in the README.md for that CIP; and perhaps, the root cause of the problem: why does this CIP reference (what should be) the same schema twice.

I'd advise to:

  1. Fix the standalone shema.json
  2. Remove completely the full schema from the README
  3. Refer to the standalone schema.json in the README, in place where the schema was inlined.

@mkazlauskas
Copy link
Author

The problem is that the schema.json file does not match the schema given in the README.md for that CIP; and perhaps, the root cause of the problem: why does this CIP reference (what should be) the same schema twice.

Indeed the social contacts are not required in README, didn't notice that. It's also aligned with what's on cips.cardano.org

KtorZ added a commit that referenced this issue Nov 23, 2021
  This overrides the previous schema and gives priority to the newest version that is in the README. It corresponds to the schema of the latest commit from the PR #15:

  4006d06

  Fixes #142.
KtorZ added a commit that referenced this issue Nov 23, 2021
  This overrides the previous schema and gives priority to the newest version that is in the README. It corresponds to the schema of the latest commit from the PR #15:

  4006d06

  Fixes #142.
crptmppt pushed a commit that referenced this issue Dec 7, 2021
* Fix CI build for authors without email.

* CIP-0006: Move README's schema as separate schema.json

  This overrides the previous schema and gives priority to the newest version that is in the README. It corresponds to the schema of the latest commit from the PR #15:

  4006d06

  Fixes #142.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants