Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new inputs to workflow summary and correct conditional statement. #1712

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

TrevorBenson
Copy link
Collaborator

@TrevorBenson TrevorBenson commented Nov 28, 2023

Description

Use correct syntax to access workflow input variables for Docker Image workflow. Adds GUILD_DEPLOY_BRANCH and Push to GA Registry as the inverse of testing boolean.

Where should the reviewer start?

Check job summaries from the How has this been tested? section.

Motivation and context

Fixes a mistake in the if condition for the push and adds the details to the summary output.

Which issue it fixes?

N/A / CI

How has this been tested?

Jobs:

Examples

Summary for a GA Image build:

Summary Details
Docker Image: docker.io/***/cardano-node:8.1.2
G_ACCOUNT: cardano-community
GUILD_DEPLOY_BRANCH: master
Push to GA Registry: true
CNVERSION: 8.1.2

Summary for a test Image build:

Summary Details
Docker Image: docker.io/***/cardano-node:8.1.2
G_ACCOUNT: cardano-community
GUILD_DEPLOY_BRANCH: alpha
Push to GA Registry: false
CNVERSION: 8.1.2

@TrevorBenson TrevorBenson requested review from rdlrt and Scitz0 November 28, 2023 07:27
Scitz0 and others added 2 commits November 28, 2023 19:02
@rdlrt rdlrt force-pushed the alpha branch 3 times, most recently from 13e3c24 to 0d4717d Compare November 29, 2023 07:30
@rdlrt rdlrt merged commit 7f2bf3b into alpha Nov 29, 2023
@rdlrt rdlrt deleted the event-input-for-workflow-dispatch-and-summary branch November 29, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants